From 2076d256539c572f407c490d924ad7322fc58599 Mon Sep 17 00:00:00 2001
From: Humza Shahid <humzasaur@gmail.com>
Date: Wed, 24 Sep 2025 17:58:37 +0100
Subject: [PATCH] begin reimplementing 'MakeNormalDelete.deleteLine' function

---
 fcore/normal-mode/make-normal-delete.sml | 50 ++++++++++++------------
 fcore/normal-mode/normal-mode-with.sml   | 30 ++++++++++++++
 2 files changed, 56 insertions(+), 24 deletions(-)

diff --git a/fcore/normal-mode/make-normal-delete.sml b/fcore/normal-mode/make-normal-delete.sml
index 22e0e2f..7f824bf 100644
--- a/fcore/normal-mode/make-normal-delete.sml
+++ b/fcore/normal-mode/make-normal-delete.sml
@@ -351,34 +351,36 @@ struct
       val startIdx = Cursor.vi0 (buffer, cursorIdx)
       val buffer = LineGap.goToIdx (startIdx, buffer)
 
-      val finishIdx = Cursor.viDlr (buffer, cursorIdx, count) + 2
-      val length = finishIdx - startIdx
+      val startLine =
+        if cursorIdx = startIdx then
+          LineGap.idxToLineNumber (cursorIdx + 1, buffer)
+        else
+          LineGap.idxToLineNumber (cursorIdx + 1, buffer)
+      val endLine = startLine + count
 
-      val textLengthBeforeDelete = #textLength buffer
+      val buffer = LineGap.goToLine (endLine, buffer)
+      val endLineIdx = LineGap.lineNumberToIdx (endLine, buffer)
+      val buffer = LineGap.goToIdx (endLineIdx - 1, buffer)
 
-      val buffer = LineGap.goToIdx (startIdx, buffer)
-      val initialMsg = Fn.initMsgs (startIdx, length, buffer)
-      val buffer = LineGap.delete (startIdx, length, buffer)
+      (* get "real" endLine by not considering newline after non-newline *)
+      val endLine =
+        if Cursor.isOnNewlineAfterChr (buffer, endLineIdx - 1) then
+          LineGap.idxToLineNumber (endLineIdx - 1, buffer)
+        else
+          LineGap.idxToLineNumber (endLineIdx, buffer)
     in
-      if finishIdx >= textLengthBeforeDelete - 1 then
-        (* we deleted to the end of the buffer.
-         * Let's check if there is a newline at the end
-         * and insert one if there isn't. *)
-        let
-          val lastPosAfterDelete = #textLength buffer - 1
-          val buffer = LineGap.goToIdx (lastPosAfterDelete, buffer)
-          val buffer =
-            if lastPosAfterDelete < 0 then
-              LineGap.append ("\n", buffer)
-            else if Cursor.isCursorAtStartOfLine (buffer, lastPosAfterDelete) then
-              buffer
-            else
-              LineGap.append ("\n", buffer)
-        in
-          finishAfterDeletingBuffer (app, startIdx, buffer, time, initialMsg)
-        end
+      if endLineIdx = #textLength buffer andalso endLine = startLine then
+        (* cursor is already on last line so not deleting *)
+        NormalModeWith.bufferMsgsAndMode (app, buffer, [], NORMAL_MODE "")
       else
-        finishAfterDeletingBuffer (app, startIdx, buffer, time, initialMsg)
+        let
+          val () = print "not on last line so have to delete\n"
+          val () = print
+            ("startLine = " ^ Int.toString startLine ^ "; endLine = "
+             ^ Int.toString endLine ^ "\n")
+        in
+          raise Fail ""
+        end
     end
 
   fun finishDeleteLineBack (app, buffer, lineIdx, length, endOfLine, time) =
diff --git a/fcore/normal-mode/normal-mode-with.sml b/fcore/normal-mode/normal-mode-with.sml
index 7646245..a4004bb 100644
--- a/fcore/normal-mode/normal-mode-with.sml
+++ b/fcore/normal-mode/normal-mode-with.sml
@@ -2,6 +2,36 @@ structure NormalModeWith =
 struct
   open AppType
 
+  fun bufferMsgsAndMode (app: app_type, newBuffer, newMsgs, newMode) =
+    let
+      val
+        { mode = _
+        , buffer = _
+        , msgs = _
+        , bufferModifyTime
+        , windowWidth
+        , windowHeight
+        , searchList
+        , visualScrollColumn
+        , searchString
+        , startLine
+        , cursorIdx
+        } = app
+    in
+      { mode = newMode
+      , buffer = newBuffer
+      , msgs = newMsgs
+      , bufferModifyTime = bufferModifyTime
+      , windowWidth = windowWidth
+      , windowHeight = windowHeight
+      , searchList = searchList
+      , visualScrollColumn = visualScrollColumn
+      , searchString = searchString
+      , startLine = startLine
+      , cursorIdx = cursorIdx
+      }
+    end
+
   fun bufferAndSize
     ( app: app_type
     , newBuffer