From 79a0c95a58b1ed20d7111c3121c8565ef0d3dec0 Mon Sep 17 00:00:00 2001
From: Humza Shahid <humzasaur@gmail.com>
Date: Sun, 18 Jan 2026 06:52:49 +0000
Subject: [PATCH] implement another case for 'PersistentVector.merge': merge
 when right depth is greater than left depth

---
 fcore/persistent-vector.sml | 41 +++++++++++++++++++++++++++++++------
 1 file changed, 35 insertions(+), 6 deletions(-)

diff --git a/fcore/persistent-vector.sml b/fcore/persistent-vector.sml
index 5fe67e8..e7eb3f0 100644
--- a/fcore/persistent-vector.sml
+++ b/fcore/persistent-vector.sml
@@ -656,13 +656,42 @@ struct
           \left and right should both be BRANCH or both be LEAF \
           \but one is BRANCH and one is LEAF"
 
-  fun merge (left, right) = 
-  let
-    val leftDepth = countDepth left
-    val rightDepth = countDepth right
-  in
-    if leftDepth = rightDepth then
+  fun mergeWhenRightDepthIsGreater (left, right, leftDepth, curDepth) =
+    if curDepth = leftDepth then
       mergeSameDepth (left, right)
+    else
+      case right of
+        BRANCH (nodes, sizes) =>
+          let
+            val child = mergeWhenRightDepthIsGreater
+              (left, Vector.sub (nodes, 0), leftDepth, curDepth + 1)
+
+            val oldChildSize = Vector.sub (sizes, 0)
+            val newChildSize = getFinishIdx child
+            val difference = newChildSize - oldChildSize
+
+            val nodes = Vector.update (nodes, 0, child)
+            val sizes = 
+              Vector.map (fn el => el + difference)
+          in
+            BRANCH (nodes, sizes)
+          end
+      | LEAF _ =>
+          raise Fail "PersistentVector.mergeWhenRightDepthIsGreater: \
+          \reached LEAF before (curDepth = leftDepth)"
+
+  fun merge (left, right) = 
+    let
+      val leftDepth = countDepth left
+      val rightDepth = countDepth right
+    in
+      if leftDepth = rightDepth then
+        mergeSameDepth (left, right)
+      else if leftDepth < rightDepth then
+        mergeWhenRightDepthIsGreater (left, right, leftDepth, 0)
+      else
+        mergeWhenLeftDepthIsGreater (left, right, rightDepth, 0)
+    end
 
   fun delete (start, length, tree) =
     if isEmpty tree then