humza/sml-projects
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

in normal mode, when we receive an event which we don't want to handle (like enter), we clear the app's mode and command history instead of simply returning the same app unmodified. This fixes a bug: say we pres 'f' to go to a character and then press enter. Before this commit, pressing a character after that 'enter' will go to that character. This is contrary to Vim, which resets the command history on an invalid command, and now we reset the command history too.

Browse Source
This commit is contained in:
Humza Shahid
2025-09-06 01:40:32 +01:00
parent 58e74afffb
commit 9369bbed93
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
fcore/normal-mode/normal-mode.sml
View File

@@ -401,10 +401,10 @@ struct
* is also possible through other keys, * is also possible through other keys,
* and it is better to use those othe keys to encourage * and it is better to use those othe keys to encourage
* staying on the home row. *) * staying on the home row. *)
| KEY_ENTER => app | KEY_ENTER => NormalFinish.clearMode app
| KEY_BACKSPACE => app | KEY_BACKSPACE => NormalFinish.clearMode app
| ARROW_RIGHT => app | ARROW_RIGHT => NormalFinish.clearMode app
| ARROW_LEFT => app | ARROW_LEFT => NormalFinish.clearMode app
| ARROW_UP => app | ARROW_UP => NormalFinish.clearMode app
| ARROW_DOWN => app | ARROW_DOWN => NormalFinish.clearMode app
end end