From e37e04a2a22b3efb8a5307821c94e05e8718c63e Mon Sep 17 00:00:00 2001 From: Humza Shahid Date: Tue, 13 Jan 2026 23:40:29 +0000 Subject: [PATCH] rename 'NormalDelete.deleteLineBack' function to 'NormalDelete.deleteLineUp' which is clearer ('k' in 'dk' motion means move cursor up one line) --- fcore/normal-mode/make-normal-delete.sml | 8 ++++---- fcore/normal-mode/normal-mode.sml | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/fcore/normal-mode/make-normal-delete.sml b/fcore/normal-mode/make-normal-delete.sml index dc924c8..0508045 100644 --- a/fcore/normal-mode/make-normal-delete.sml +++ b/fcore/normal-mode/make-normal-delete.sml @@ -584,7 +584,7 @@ struct end end - fun finishDeleteLineBack (app, buffer, lineIdx, length, endOfLine, time) = + fun finishDeleteLineUp (app, buffer, lineIdx, length, endOfLine, time) = if endOfLine >= #textLength buffer - 2 then (* deleting from last line *) let @@ -632,7 +632,7 @@ struct finishAfterDeletingBuffer (app, newCursorIdx, buffer, time, initialMsg) end - fun deleteLineBack (app: app_type, count, time) = + fun deleteLineUp (app: app_type, count, time) = let val {buffer, cursorIdx, ...} = app val buffer = LineGap.goToIdx (cursorIdx, buffer) @@ -662,7 +662,7 @@ struct else endOfLine + 2 in - finishDeleteLineBack (app, buffer, 0, endOfLine, endOfLine, time) + finishDeleteLineUp (app, buffer, 0, endOfLine, endOfLine, time) end else let @@ -686,7 +686,7 @@ struct val lineIdx = LineGap.lineNumberToIdx (newCursorLineNumber, buffer) val length = endOfLine - lineIdx in - finishDeleteLineBack (app, buffer, lineIdx, length, endOfLine, time) + finishDeleteLineUp (app, buffer, lineIdx, length, endOfLine, time) end end diff --git a/fcore/normal-mode/normal-mode.sml b/fcore/normal-mode/normal-mode.sml index 9532c59..f2f6a75 100644 --- a/fcore/normal-mode/normal-mode.sml +++ b/fcore/normal-mode/normal-mode.sml @@ -265,7 +265,7 @@ struct * so their implementation differs from * other cursor motions *) | #"j" => NormalDelete.deleteLineDown (app, count, time) - | #"k" => NormalDelete.deleteLineBack (app, count, time) + | #"k" => NormalDelete.deleteLineUp (app, count, time) | #"w" => NormalDelete.deleteWord (app, count, time) | #"W" => NormalDelete.deleteWORD (app, count, time) | #"b" => NormalDelete.deleteByDfa (app, count, Cursor.prevWord, time) @@ -365,7 +365,7 @@ struct * so their implementation differs from * other cursor motions *) | #"j" => NormalYankDelete.deleteLineDown (app, count, time) - | #"k" => NormalYankDelete.deleteLineBack (app, count, time) + | #"k" => NormalYankDelete.deleteLineUp (app, count, time) | #"w" => NormalYankDelete.deleteWord (app, count, time) | #"W" => NormalYankDelete.deleteWORD (app, count, time) | #"b" => NormalYankDelete.deleteByDfa (app, count, Cursor.prevWord, time)