From ee58556bdef3284d69f1c5faf086445a44a6e8f4 Mon Sep 17 00:00:00 2001
From: Humza Shahid <humzasaur@gmail.com>
Date: Sat, 17 Jan 2026 23:14:05 +0000
Subject: [PATCH] progress implementing 'PersistentVector.delete'. (Todo:
 implement function to merge left and right vectors.)

---
 fcore/persistent-vector.sml | 47 +++++++++++++++++++++++++++++++++++++
 1 file changed, 47 insertions(+)

diff --git a/fcore/persistent-vector.sml b/fcore/persistent-vector.sml
index 11aca07..f16f0e3 100644
--- a/fcore/persistent-vector.sml
+++ b/fcore/persistent-vector.sml
@@ -57,6 +57,15 @@ struct
       BRANCH (_, sizes) => Vector.sub (sizes, Vector.length sizes - 1)
     | LEAF (_, sizes) => Vector.sub (sizes, Vector.length sizes - 1)
 
+  fun getStartIdx t =
+    case t of
+      BRANCH (nodes, _) => getStartIdx (Vector.sub (nodes,  0))
+    | LEAF (items, _) => 
+        if Vector.length items = 0 then
+          0
+        else
+          #start (Vector.sub (items, 0))
+
   fun helpAppend (start, finish, tree) =
     case tree of
       BRANCH (nodes, sizes) =>
@@ -536,6 +545,44 @@ struct
 
   fun countDepth tree = countDepthLoop (0, tree)
 
+  fun merge (left, right) = raise Fail "unimplemennted"
+
+  fun delete (start, finish, tree) =
+    let
+      val matchAfterFinish = nextMatch (finish, tree, 1)
+      val left = splitRight (start, tree)
+    in
+      if  matchAfterFinish = ~1 then
+        (* there is no match after 'finish', so just split left. 
+         * No need to decrement or split right, 
+         * because the right vector would be empty. *)
+        left
+      else
+        let
+          val right = splitRight (finish, tree)
+        in
+          if isEmpty right then
+            left
+          else
+            let
+              val leftSize = getFinishIdx left
+              val rightStartRelative = getStartIdx right
+
+              val rightStartAbsolute = leftSize + rightStartRelative
+              val difference = matchAfterFinish - rightStartAbsolute
+            in
+              if difference = 0 then
+                merge (left, right)
+              else
+                let
+                  val right = decrementBy (difference, right)
+                in
+                  merge (left, right)
+                end
+            end
+        end
+    end
+
   (* functions only for testing *)
   fun fromListLoop (lst, acc) =
     case lst of