|
|
5503b8ebda
|
add failing test for 'dw' motion
|
2025-09-26 05:27:48 +01:00 |
|
|
|
b31d7650a8
|
change the way we calculate the newCursorIdx when we delete using the 'dk' motion while on the last line. We go to the buffer's last line and find the first column. This more directly expresses what we want and now passes the failing unit test for 'dk'.
|
2025-09-25 14:59:29 +01:00 |
|
|
|
05abecc70d
|
pass a failing test for 'dk' motion by decrementing newCursorLineNumber if the end of the deletion range is on a newline, and it is also the last char in the buffer
|
2025-09-25 14:44:39 +01:00 |
|
|
|
1494d5c356
|
add two new unit tests for 'dk' motion
|
2025-09-25 13:58:56 +01:00 |
|
|
|
6b0149162f
|
a bit of formatting
|
2025-09-25 10:50:02 +01:00 |
|
|
|
bf55373f6d
|
fix 'MakeNormalDelete.deleteLineBack' test, which failed because we were using the wrong way to check if cursor is currently at the start of the line. We checked '(endOfLine = cursorIdx) which works in most cases to verify that the current position is a newline, but fails when the cursor is at the last non-newline character of the line. This is fixed by being more precise and calling 'Cursor.isCursorAtStartOfLine' to check directly if the cursor is currently at the end of the line.
|
2025-09-25 10:49:20 +01:00 |
|
|
|
1f5e933772
|
add failing test for 'dk' motion, when cursor is on last character of line
|
2025-09-25 10:38:57 +01:00 |
|
|
|
c13ef69a9e
|
pass failing test for 'dk' by paying attention to newlines
|
2025-09-25 10:31:02 +01:00 |
|
|
|
5610ccf630
|
more descriptive name for one test
|
2025-09-25 10:04:37 +01:00 |
|
|
|
594367d6d8
|
add another failing unit test for 'dk' motion
|
2025-09-25 10:02:16 +01:00 |
|
|
|
1921f87191
|
handle edge case which deleted newline incorrectly when it shouldn't, passing failing test for 'dk' motion
|
2025-09-25 09:49:37 +01:00 |
|
|
|
75b4f11822
|
add failing test for 'dk' motion
|
2025-09-25 09:30:07 +01:00 |
|
|
|
de8f5b7761
|
add a few more tests for 'dk' motion
|
2025-09-25 09:19:15 +01:00 |
|
|
|
02cc5a0e53
|
make failing test for 'dk' motion pass by appending a newline to the buffer if the buffer becomes empty
|
2025-09-25 09:09:18 +01:00 |
|
|
|
2c3eb6a8a1
|
begin adding tests for 'dk' motion
|
2025-09-25 09:03:40 +01:00 |
|
|
|
0255b127a7
|
fix minor bug in make-dfa-loop.sml: when folding backwards using an if-statement, make sure we start folding from the leftStrings if the cursorIdx < 0
|
2025-09-25 08:34:23 +01:00 |
|
|
|
5264cbfac8
|
add tests for 'dd' motion, and they all pass
|
2025-09-25 07:15:17 +01:00 |
|
|
|
1000e74183
|
pass failing test for 'dj' motion through a different startLine calculation depending on whether cursor is already on a newline or not
|
2025-09-25 06:34:08 +01:00 |
|
|
|
cddd03812b
|
implement first pass of 'MakeNormalDelete.deleteLine'; have to add tests for this next
|
2025-09-25 06:23:12 +01:00 |
|
|
|
efaadf1337
|
a bit of refactoring
|
2025-09-25 06:18:12 +01:00 |
|
|
|
b73117d075
|
add failing test for 'dj' motion, and progress reimplementing 'MakeNormalDelete.deleteLine'
|
2025-09-25 06:11:36 +01:00 |
|
|
|
d25a06a9ed
|
progress reimplementing 'MakeNormalDelete.deleteLine
|
2025-09-25 06:04:11 +01:00 |
|
|
|
11015dfa9e
|
add two more test cases for 'dj' motion that were failing when added, and modify 'MakeNormalDelete.deleteLineDown' to handle them
|
2025-09-25 05:28:13 +01:00 |
|
|
|
e24230834e
|
rename existing 'MakeNormalDelete.deleteLine' function to 'MakeNormalDelete.deleteLineDown', make 'dj' and 'ydj' commands use the renamed function, and add a new 'MakeNormalDelete.deleteLine' function (which has no implementation yet). We do this because we want to distinguish between 'dd' and 'dj' commands, allowing 'dd' to delete to the end of the file despite any count, while stoppinhg 'dj' from deleting the file when on the last line.
|
2025-09-25 04:56:25 +01:00 |
|
|
|
1255238d6c
|
pass failing tests for 'dj' motion
|
2025-09-24 19:32:31 +01:00 |
|
|
|
2076d25653
|
begin reimplementing 'MakeNormalDelete.deleteLine' function
|
2025-09-24 17:58:37 +01:00 |
|
|
|
80078196e0
|
if 'MakeNormalDelete.deleteLine' deletes to the end of the file such that there is no newline at the end, then append a newline. This makes one of the tests we have pass.
|
2025-09-24 13:05:13 +01:00 |
|
|
|
222a9aa43c
|
fix 'MakeNormalDelete.removeChr' by accounting for case when we are deleting from last line but the last line does not end with its own newline
|
2025-09-24 09:46:28 +01:00 |
|
|
|
e70aab8952
|
add another failing test for 'dl' motion
|
2025-09-24 09:07:26 +01:00 |
|
|
|
95393e1e13
|
amand MakeNormalDelete.removeChr function (which is used by 'x' and 'dh' commands) to pass test, which checks that cursorIdx does not fall on newline-after-chr after deletion
|
2025-09-24 09:02:33 +01:00 |
|
|
|
c500704f04
|
add failing tests for 'dj' motion
|
2025-09-24 08:54:13 +01:00 |
|
|
|
a8bc405727
|
add failing test for 'dl' motion
|
2025-09-24 07:58:45 +01:00 |
|
|
|
00ab086257
|
remove code related to appending newlines in 'MakeNormalDelete', as we have decided that we allow files which do not end in newlines as well as files that do
|
2025-09-24 07:18:11 +01:00 |
|
|
|
51a7c358ca
|
found bug in '0' motion, added test for it, and fixed it as well
|
2025-09-23 16:05:23 +01:00 |
|
|
|
9a15b1715a
|
pass all tests for 'j' motion
|
2025-09-23 15:30:28 +01:00 |
|
|
|
95a4f109bd
|
progress reimplementing 'j' motion to pass new tests
|
2025-09-23 15:22:49 +01:00 |
|
|
|
c3ca8dddf4
|
add additional failing unit test for 'j' motion
|
2025-09-23 13:30:54 +01:00 |
|
|
|
109fda187a
|
add a new failing test, and modify 'TestUtils.init' function (which takes a string and returns an AppType.app_type) so that it does not automatically add a newline to the end of strings. (This modification required changing the strings in some tests, as those strings did not have newlines at the end but the test assumes they did.)
|
2025-09-23 13:18:36 +01:00 |
|
|
|
2376ae07b5
|
fix tests which broke due to a design decision (how to handle newlines)
|
2025-09-23 12:15:14 +01:00 |
|
|
|
fcc8c8085a
|
reimplement 'G' motion so that it follows new rule (cursor goes to second-last chr if last chr is a newline preceded by a non-newline, but goes to last chr otherwise)
|
2025-09-23 11:57:19 +01:00 |
|
|
|
5d20b81bcc
|
adjust functor to move by dfa so that we cannot go to the last char of the file if (last char is a newline and is preceded by a non-newline), but otherwise we can go to the last char of the file.
|
2025-09-23 11:47:25 +01:00 |
|
|
|
5fded45303
|
remove redundant test
|
2025-09-23 11:11:33 +01:00 |
|
|
|
4f20379219
|
take care of a few tests after refactoring/making a different design decision
|
2025-09-23 11:04:47 +01:00 |
|
|
|
961ce63023
|
begin refactoring to let cursor move to very last char of file (including unix line ending)
|
2025-09-23 10:50:10 +01:00 |
|
|
|
8931d4d071
|
fix minor compilation error introduced in previous commit
|
2025-09-23 09:29:02 +01:00 |
|
|
|
ec462a4df7
|
remove special case from 'k' motion: the exact semantics we want for trailing newlines at the end of a file are currently a bit unclear and require exploration
|
2025-09-23 09:27:13 +01:00 |
|
|
|
21e12addf3
|
in text builders, check when on newline if this is the second last character in the file, and draw it on a newline if so. This is to align with the design decision that we want the second-last character to be selectable
|
2025-09-23 09:16:02 +01:00 |
|
|
|
505521f5e2
|
minor cosmetic change
|
2025-09-23 09:04:18 +01:00 |
|
|
|
6be1d48b02
|
add test for 'k' motion: when file ends with two newlines and cursor is on newline_1 in the pattern (char -> newline_1 -> newline_2), we should be able to move up by a line
|
2025-09-23 09:00:50 +01:00 |
|
|
|
c9365076ad
|
handle special case with 'k' motion: when file ends with \n\n and cursor is on first \n: we should be able to move upwards from here too
|
2025-09-23 08:54:19 +01:00 |
|
