|
|
b73117d075
|
add failing test for 'dj' motion, and progress reimplementing 'MakeNormalDelete.deleteLine'
|
2025-09-25 06:11:36 +01:00 |
|
|
|
d25a06a9ed
|
progress reimplementing 'MakeNormalDelete.deleteLine
|
2025-09-25 06:04:11 +01:00 |
|
|
|
11015dfa9e
|
add two more test cases for 'dj' motion that were failing when added, and modify 'MakeNormalDelete.deleteLineDown' to handle them
|
2025-09-25 05:28:13 +01:00 |
|
|
|
e24230834e
|
rename existing 'MakeNormalDelete.deleteLine' function to 'MakeNormalDelete.deleteLineDown', make 'dj' and 'ydj' commands use the renamed function, and add a new 'MakeNormalDelete.deleteLine' function (which has no implementation yet). We do this because we want to distinguish between 'dd' and 'dj' commands, allowing 'dd' to delete to the end of the file despite any count, while stoppinhg 'dj' from deleting the file when on the last line.
|
2025-09-25 04:56:25 +01:00 |
|
|
|
1255238d6c
|
pass failing tests for 'dj' motion
|
2025-09-24 19:32:31 +01:00 |
|
|
|
2076d25653
|
begin reimplementing 'MakeNormalDelete.deleteLine' function
|
2025-09-24 17:58:37 +01:00 |
|
|
|
80078196e0
|
if 'MakeNormalDelete.deleteLine' deletes to the end of the file such that there is no newline at the end, then append a newline. This makes one of the tests we have pass.
|
2025-09-24 13:05:13 +01:00 |
|
|
|
222a9aa43c
|
fix 'MakeNormalDelete.removeChr' by accounting for case when we are deleting from last line but the last line does not end with its own newline
|
2025-09-24 09:46:28 +01:00 |
|
|
|
e70aab8952
|
add another failing test for 'dl' motion
|
2025-09-24 09:07:26 +01:00 |
|
|
|
95393e1e13
|
amand MakeNormalDelete.removeChr function (which is used by 'x' and 'dh' commands) to pass test, which checks that cursorIdx does not fall on newline-after-chr after deletion
|
2025-09-24 09:02:33 +01:00 |
|
|
|
c500704f04
|
add failing tests for 'dj' motion
|
2025-09-24 08:54:13 +01:00 |
|
|
|
a8bc405727
|
add failing test for 'dl' motion
|
2025-09-24 07:58:45 +01:00 |
|
|
|
00ab086257
|
remove code related to appending newlines in 'MakeNormalDelete', as we have decided that we allow files which do not end in newlines as well as files that do
|
2025-09-24 07:18:11 +01:00 |
|
|
|
51a7c358ca
|
found bug in '0' motion, added test for it, and fixed it as well
|
2025-09-23 16:05:23 +01:00 |
|
|
|
9a15b1715a
|
pass all tests for 'j' motion
|
2025-09-23 15:30:28 +01:00 |
|
|
|
95a4f109bd
|
progress reimplementing 'j' motion to pass new tests
|
2025-09-23 15:22:49 +01:00 |
|
|
|
c3ca8dddf4
|
add additional failing unit test for 'j' motion
|
2025-09-23 13:30:54 +01:00 |
|
|
|
109fda187a
|
add a new failing test, and modify 'TestUtils.init' function (which takes a string and returns an AppType.app_type) so that it does not automatically add a newline to the end of strings. (This modification required changing the strings in some tests, as those strings did not have newlines at the end but the test assumes they did.)
|
2025-09-23 13:18:36 +01:00 |
|
|
|
2376ae07b5
|
fix tests which broke due to a design decision (how to handle newlines)
|
2025-09-23 12:15:14 +01:00 |
|
|
|
fcc8c8085a
|
reimplement 'G' motion so that it follows new rule (cursor goes to second-last chr if last chr is a newline preceded by a non-newline, but goes to last chr otherwise)
|
2025-09-23 11:57:19 +01:00 |
|
|
|
5d20b81bcc
|
adjust functor to move by dfa so that we cannot go to the last char of the file if (last char is a newline and is preceded by a non-newline), but otherwise we can go to the last char of the file.
|
2025-09-23 11:47:25 +01:00 |
|
|
|
5fded45303
|
remove redundant test
|
2025-09-23 11:11:33 +01:00 |
|
|
|
4f20379219
|
take care of a few tests after refactoring/making a different design decision
|
2025-09-23 11:04:47 +01:00 |
|
|
|
961ce63023
|
begin refactoring to let cursor move to very last char of file (including unix line ending)
|
2025-09-23 10:50:10 +01:00 |
|
|
|
8931d4d071
|
fix minor compilation error introduced in previous commit
|
2025-09-23 09:29:02 +01:00 |
|
|
|
ec462a4df7
|
remove special case from 'k' motion: the exact semantics we want for trailing newlines at the end of a file are currently a bit unclear and require exploration
|
2025-09-23 09:27:13 +01:00 |
|
|
|
21e12addf3
|
in text builders, check when on newline if this is the second last character in the file, and draw it on a newline if so. This is to align with the design decision that we want the second-last character to be selectable
|
2025-09-23 09:16:02 +01:00 |
|
|
|
505521f5e2
|
minor cosmetic change
|
2025-09-23 09:04:18 +01:00 |
|
|
|
6be1d48b02
|
add test for 'k' motion: when file ends with two newlines and cursor is on newline_1 in the pattern (char -> newline_1 -> newline_2), we should be able to move up by a line
|
2025-09-23 09:00:50 +01:00 |
|
|
|
c9365076ad
|
handle special case with 'k' motion: when file ends with \n\n and cursor is on first \n: we should be able to move upwards from here too
|
2025-09-23 08:54:19 +01:00 |
|
|
|
494d56e997
|
add two new tests to check that 'w' motion does not let cursor go to last newline in file, but does let cursor go to second-last newline
|
2025-09-23 08:20:40 +01:00 |
|
|
|
79d232df7a
|
amend very minor bug: when looping through DFA and hitting a 'final state', we let the next chr afterwards handle the start state, but we want the current char to handle the start state instead, as this matches vim's behaviour
|
2025-09-23 07:36:51 +01:00 |
|
|
|
0b0d5268fc
|
handle edge case when deleting by DFA: when we are deleting to the end of the file and if cursor is on first character after newline, then we also want to delete preceding newline too. Or else we will end up with two newlines at the end of the file, which is not what we want.
|
2025-09-23 07:18:58 +01:00 |
|
|
|
ec10f3e025
|
tiny amount of formatting
|
2025-09-23 07:04:41 +01:00 |
|
|
|
9174e4923c
|
don't deleteByDfa when buffer's length is 1, because that would mean that we would be deleting last newline in file
|
2025-09-23 07:04:20 +01:00 |
|
|
|
02ada5765b
|
improve 'MakeNormalDelete.deleteByDfa' function by refraining from deleting the unix-style line ending, if DFA takes us past the ending
|
2025-09-23 06:09:03 +01:00 |
|
|
|
12bd30d9dd
|
pull in new version of brolib-sml, which contains a bug fix for 'LineGap.delete'
|
2025-09-22 15:07:45 +01:00 |
|
|
|
cb0dec93a0
|
simplify implementation of 'MakeNormalDelete.deleteLine
|
2025-09-22 13:02:08 +01:00 |
|
|
|
e3148e6ac1
|
when deleting using a DFA motion, make sure we have a linebreak at the end so that we still have unix-style line endings as an invariant
|
2025-09-22 12:41:33 +01:00 |
|
|
|
351f7e9bf9
|
fix edge case with 'd$' motion: if deleting to end of file, we need to append two newlines
|
2025-09-22 12:28:08 +01:00 |
|
|
|
d3c6031b19
|
pull in new version of brolib-sml, which has bug fixes for line_gap.sml's 'lineNumberToIdx' function
|
2025-09-22 10:30:00 +01:00 |
|
|
|
6f968ee8e5
|
in 'dk' motion, make sure we move the cursor to the start of the previous line in all cases
|
2025-09-22 09:46:43 +01:00 |
|
|
|
90eeb6e570
|
restore temp.txt to original version, as it was being edited for testing purposes
|
2025-09-22 07:46:45 +01:00 |
|
|
|
a890381f2a
|
amend vi's 'k' tests after having reimplemented 'k' motion
|
2025-09-22 07:13:04 +01:00 |
|
|
|
e6ea96f995
|
fix bug in 'k' motion: when we move from any other line to line 0, always unconditionally decrement column by 1
|
2025-09-22 07:02:20 +01:00 |
|
|
|
3128647a5f
|
reimplement 'k' motion so that newlines which are immediately preceded by non-newline chars are skipped
|
2025-09-22 06:49:00 +01:00 |
|
|
|
4dc73aa4d6
|
amend tests for vi's 'j' motion, after having reimplemented it
|
2025-09-22 05:37:54 +01:00 |
|
|
|
5315aff600
|
reimplement 'j' motion so that newline is skipped only if immediately preceded by char
|
2025-09-22 05:32:03 +01:00 |
|
|
|
8ca8d1db29
|
add new tests for 'l' motion to ensure that newlines are only skipped when they are preceded by chars
|
2025-09-22 04:10:39 +01:00 |
|
|
|
4c5c1f304a
|
amend a test to respect new viH implementation
|
2025-09-21 21:45:30 +01:00 |
|
