humza/sml-projects
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

rename 'NormalDelete.deleteLineBack' function to 'NormalDelete.deleteLineUp' which is clearer ('k' in 'dk' motion means move cursor up one line)

Browse Source
This commit is contained in:
Humza Shahid
2026-01-13 23:40:29 +00:00
parent f1dd822d5b
commit e37e04a2a2
2 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
fcore/normal-mode/make-normal-delete.sml
View File

@@ -584,7 +584,7 @@ struct
end
end
fun finishDeleteLineBack (app, buffer, lineIdx, length, endOfLine, time) =
fun finishDeleteLineUp (app, buffer, lineIdx, length, endOfLine, time) =
if endOfLine >= #textLength buffer - 2 then
(* deleting from last line *)
let
@@ -632,7 +632,7 @@ struct
finishAfterDeletingBuffer (app, newCursorIdx, buffer, time, initialMsg)
end
fun deleteLineBack (app: app_type, count, time) =
fun deleteLineUp (app: app_type, count, time) =
let
val {buffer, cursorIdx, ...} = app
val buffer = LineGap.goToIdx (cursorIdx, buffer)
@@ -662,7 +662,7 @@ struct
else
endOfLine + 2
in
finishDeleteLineBack (app, buffer, 0, endOfLine, endOfLine, time)
finishDeleteLineUp (app, buffer, 0, endOfLine, endOfLine, time)
end
else
let
@@ -686,7 +686,7 @@ struct
val lineIdx = LineGap.lineNumberToIdx (newCursorLineNumber, buffer)
val length = endOfLine - lineIdx
in
finishDeleteLineBack (app, buffer, lineIdx, length, endOfLine, time)
finishDeleteLineUp (app, buffer, lineIdx, length, endOfLine, time)
end
end

4
fcore/normal-mode/normal-mode.sml
View File

@@ -265,7 +265,7 @@ struct
* so their implementation differs from
* other cursor motions *)
| #"j" => NormalDelete.deleteLineDown (app, count, time)
| #"k" => NormalDelete.deleteLineBack (app, count, time)
| #"k" => NormalDelete.deleteLineUp (app, count, time)
| #"w" => NormalDelete.deleteWord (app, count, time)
| #"W" => NormalDelete.deleteWORD (app, count, time)
| #"b" => NormalDelete.deleteByDfa (app, count, Cursor.prevWord, time)
@@ -365,7 +365,7 @@ struct
* so their implementation differs from
* other cursor motions *)
| #"j" => NormalYankDelete.deleteLineDown (app, count, time)
| #"k" => NormalYankDelete.deleteLineBack (app, count, time)
| #"k" => NormalYankDelete.deleteLineUp (app, count, time)
| #"w" => NormalYankDelete.deleteWord (app, count, time)
| #"W" => NormalYankDelete.deleteWORD (app, count, time)
| #"b" => NormalYankDelete.deleteByDfa (app, count, Cursor.prevWord, time)